fix: validate URL against base URL when retreiving pages of items - #271
Merged
rossiam merged 1 commit intoAug 4, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 54d8326 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rossiam
force-pushed
the
validate-base-url-on-page
branch
from
July 28, 2026 19:07
7584010 to
31c3c6b
Compare
erodewald
requested changes
Jul 29, 2026
erodewald
left a comment
erodewald
left a comment
Member
There was a problem hiding this comment.
Also rest-client.ts's RESTClientConfig still lets urlProvider be undefined at runtime. If they pass in undefined, it clobbers the default via spread, and TS won't catch that until RESTClientConfig is tightened.
e.g.,
this.config = { ...defaultConfig, ...config, urlProvider: config?.urlProvider ?? globalSmartThingsURLProvider, headers }
rossiam
force-pushed
the
validate-base-url-on-page
branch
3 times, most recently
from
July 30, 2026 14:50
5c10028 to
aa5515b
Compare
rossiam
force-pushed
the
validate-base-url-on-page
branch
from
July 30, 2026 15:24
aa5515b to
54d8326
Compare
jefreemyer
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baseURLinURLProvider(seems like a breaking change but would always fail later if this were left out)baseURLbaseURL